Skip to content

HBASE-28604 Fix the error message in ReservoirSample's constructor#5920

Merged
Apache9 merged 1 commit intoapache:masterfrom
Apache9:HBASE-28604
May 18, 2024
Merged

HBASE-28604 Fix the error message in ReservoirSample's constructor#5920
Apache9 merged 1 commit intoapache:masterfrom
Apache9:HBASE-28604

Conversation

@Apache9
Copy link
Copy Markdown
Contributor

@Apache9 Apache9 commented May 17, 2024 •
edited
Loading

No description provided.

@Apache9 Apache9 self-assigned this May 17, 2024
@Apache9 Apache9 changed the title HBASE-28604 hbase-backup/src/main/java/org/apache/hadoop/hbase/backup… HBASE-28604 Fix the error message in ReservoirSample's constructor May 17, 2024
@Apache9 Apache9 requested a review from ndimiduk May 17, 2024 15:32
@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented May 17, 2024

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 38s master passed
+1 💚 compile 0m 17s master passed
+1 💚 shadedjars 5m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 17s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 28s the patch passed
+1 💚 compile 0m 17s the patch passed
+1 💚 javac 0m 17s the patch passed
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 2m 7s hbase-common in the patch passed.
20m 32s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5920
Optional Tests javac javadoc unit shadedjars compile
uname Linux fee7969b83f8 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6c84d39
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/testReport/
Max. process+thread count 384 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented May 17, 2024

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 1s master passed
+1 💚 compile 0m 18s master passed
+1 💚 shadedjars 5m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 0m 18s the patch passed
+1 💚 javac 0m 18s the patch passed
+1 💚 shadedjars 5m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 17s the patch passed
_ Other Tests _
+1 💚 unit 2m 21s hbase-common in the patch passed.
21m 52s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5920
Optional Tests javac javadoc unit shadedjars compile
uname Linux b02ad8fd1e0c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6c84d39
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/testReport/
Max. process+thread count 389 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented May 17, 2024

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 2s master passed
+1 💚 compile 0m 38s master passed
+1 💚 checkstyle 0m 16s master passed
-1 ❌ spotless 0m 42s branch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 0m 35s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 0m 35s the patch passed
+1 💚 javac 0m 35s the patch passed
+1 💚 checkstyle 0m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 4m 58s Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌ spotless 0m 38s patch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 0m 40s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
22m 23s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5920
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux bc9e937473d3 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6c84d39
Default Java Eclipse Adoptium-11.0.17+8
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-general-check/output/branch-spotless.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link
Copy Markdown

Apache-HBase commented May 17, 2024

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 51s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 45s master passed
+1 💚 compile 0m 24s master passed
+1 💚 shadedjars 7m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 0m 30s the patch passed
+1 💚 javac 0m 30s the patch passed
+1 💚 shadedjars 6m 45s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s the patch passed
_ Other Tests _
+1 💚 unit 2m 40s hbase-common in the patch passed.
29m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5920
Optional Tests javac javadoc unit shadedjars compile
uname Linux d75adb42a02f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6c84d39
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/testReport/
Max. process+thread count 389 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5920/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 6b7aaed into apache:master May 18, 2024
Apache9 added a commit that referenced this pull request May 18, 2024
@Apache9
HBASE-28604 Fix the error message in ReservoirSample's constructor (#…
e7d0bea 
…5920)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 6b7aaed)
Apache9 added a commit that referenced this pull request May 18, 2024
@Apache9
HBASE-28604 Fix the error message in ReservoirSample's constructor (#…
fcbfbce 
…5920)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 6b7aaed)
Apache9 added a commit that referenced this pull request May 18, 2024
@Apache9
HBASE-28604 Fix the error message in ReservoirSample's constructor (#…
b674fe6 
…5920)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 6b7aaed)
Apache9 added a commit that referenced this pull request May 18, 2024
@Apache9
HBASE-28604 Fix the error message in ReservoirSample's constructor (#…
30cdcef 
…5920)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 6b7aaed)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@Apache9 @vinayakphegde
HBASE-28604 Fix the error message in ReservoirSample's constructor (a…
130b1f1 
…pache#5920)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees

@Apache9 Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9 @Apache-HBase @ndimiduk